#534241: [sitecore-jss-nextjs][middleware-redirect]added handling with token $siteLang

[sc-ruslanmatkovskyi]

• This PR follows the Contribution Guide
• Changelog updated

Description / Motivation

Added a new handling for token $siteLang(context site language) in middleware redirect

Testing Details

• Unit Test Added
• Manual Test/Other (Please elaborate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

[ambrauer]

Also, please check linting, the check is currently failing.

[ambrauer]

Looks good (approved), but I do have a question about the $siteLang token in general. If the intent is to always replace with the context site's default language, then this satisfies the requirements. However, I imagine it's more useful to replace with the context language (i.e. from NextUrl.locale).

For example, if I have a single site (default language = 'en') with 2 language versions ('en' and 'da-DK') and am using Next.js i18n sub-path routing, I would want to be able to configure a redirect target like:

pattern: /not-found > target: http://mysite.com/$contextLang/found

So that this would be the result:
http://mysite.com/en/not-found >http://mysite.com/en/found
http://mysite.com/da-DK/not-found >http://mysite.com/da-DK/found

With $siteLang, this would be the result:
http://mysite.com/en/not-found >http://mysite.com/en/found
http://mysite.com/da-DK/not-found >http://mysite.com/en/found

[sc-ruslanmatkovskyi]

Looks good (approved), but I do have a question about the $siteLang token in general. If the intent is to always replace with the context site's default language, then this satisfies the requirements. However, I imagine it's more useful to replace with the context language (i.e. from NextUrl.locale).

For example, if I have a single site (default language = 'en') with 2 language versions ('en' and 'da-DK') and am using Next.js i18n sub-path routing, I would want to be able to configure a redirect target like:

pattern: /not-found > target: http://mysite.com/$contextLang/found

So that this would be the result: http://mysite.com/en/not-found >http://mysite.com/en/found http://mysite.com/da-DK/not-found >http://mysite.com/da-DK/found

With $siteLang, this would be the result: http://mysite.com/en/not-found >http://mysite.com/en/found http://mysite.com/da-DK/not-found >http://mysite.com/en/found

Yeah, but in this situation we not use token $siteLang it will work the same without token, right?

[ambrauer]

Yeah, but in this situation we not use token $siteLang it will work the same without token, right?

Oh really? Just to confirm... You're saying that if I have this redirect configured:

pattern: /not-found > target: http://mysite.com/found

then these requests would redirect as follows?
http://mysite.com/en/not-found -> http://mysite.com/en/found
http://mysite.com/da-DK/not-found -> http://mysite.com/da-DK/found

Guess I'm just trying to think of the business value in being able to redirect to the site's configured default language (vs the route's context language).

[sc-ruslanmatkovskyi]

Yeah, but in this situation we not use token $siteLang it will work the same without token, right?

Oh really? Just to confirm... You're saying that if I have this redirect configured:

pattern: /not-found > target: http://mysite.com/found

then these requests would redirect as follows? http://mysite.com/en/not-found -> http://mysite.com/en/found http://mysite.com/da-DK/not-found -> http://mysite.com/da-DK/found

Guess I'm just trying to think of the business value in being able to redirect to the site's configured default language (vs the route's context language).

I checked it and it works so as you write

/not-found -> /redirected-link
/da/not-found /da/redirected-link