#536289: [SXA] Add custom template for _jss scaffold_ #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sc-ruslanmatkovskyi
force-pushed
the
feature/536289-implement-jss-scaffold-sxa-initializer
branch
from
ea46aae to
812fa72
Compare
ambrauer
reviewed
Apr 5, 2023
sc-ruslanmatkovskyi
force-pushed
the
feature/536289-implement-jss-scaffold-sxa-initializer
branch
from
812fa72 to
a8b8282
Compare
Yes, you're right! I fixed it |
sc-ruslanmatkovskyi
force-pushed
the
feature/536289-implement-jss-scaffold-sxa-initializer
branch
from
a8b8282 to
aa075a0
Compare
sc-ruslanmatkovskyi
changed the title
sc-dawidrutkowski
requested changes
Apr 6, 2023
packages/create-sitecore-jss/src/templates/nextjs-sxa/scripts/templates/component-src.ts
Outdated
Show resolved
Hide resolved
sc-ruslanmatkovskyi
force-pushed
the
feature/536289-implement-jss-scaffold-sxa-initializer
branch
from
aa075a0 to
c096f2e
Compare
|
@matkovskyi Please, also update CHANGELOG.md file to include your PR. We started to update Changelog for each PR, so it makes easier for us to start release processes |
sc-dawidrutkowski
approved these changes
Apr 6, 2023
sc-ruslanmatkovskyi
force-pushed
the
feature/536289-implement-jss-scaffold-sxa-initializer
branch
from
cf0bdc8 to
099100a
Compare
sc-ruslanmatkovskyi
force-pushed
the
feature/536289-implement-jss-scaffold-sxa-initializer
branch
from
099100a to
cbd2829
Compare
illiakovalenko
requested changes
Apr 6, 2023
packages/create-sitecore-jss/src/templates/nextjs-sxa/scripts/scaffold-component.ts
Outdated
Show resolved
Hide resolved
illiakovalenko
requested changes
Apr 6, 2023
illiakovalenko
changed the title
illiakovalenko
deleted the
feature/536289-implement-jss-scaffold-sxa-initializer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Added nextjs-sxa scaffold component action in initializer.
Testing Details
Types of changes