Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Other packages] Upgrade 3rd party dependencies #1321

Merged
merged 16 commits into from
Feb 7, 2023

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Feb 2, 2023

Upgraded 3rd party dependencies for:

  • create-sitecore-jss
  • sitecore-jss-cli
  • sitecore-jss-forms
  • sitecore-jss-dev-tools
  • sitecore-jss-proxy
  • sitecore-jss-rendering-host

Description / Motivation

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania requested a review from a team February 2, 2023 17:28
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on upgrades! Please, see my comments below
And I wanna ask you to provide reasons (add them to the description of PR) why some primary and vulnerable dependencies were not upgraded, like:

  • [sitecore-jss-rendering-host] webpack-dev-server
  • etc. if something else is skipped

@addy-pathania
Copy link
Contributor Author

addy-pathania commented Feb 7, 2023

Good work on upgrades! Please, see my comments below And I wanna ask you to provide reasons (add them to the description of PR) why some primary and vulnerable dependencies were not upgraded, like:

  • [sitecore-jss-rendering-host] webpack-dev-server
  • etc. if something else is skipped

Most of the packages which are not upgraded or not upgraded to the latest version is because they migrated to ESM and don't support CJS or were incompatible with other dependency versions some of them are chalk, inquirer, url-join.

For http-proxy-middleware it was incompatible with its types dependency types/http-proxy-middleware. I got various build
errors in the definition files.

Similarly for web-dev-server after upgrading it to latest it doesn't adjust well with the way our devServer.ts file is setup for e.g the here WebpackDevMiddleware.Options complains that it requires 2 arguments but typescript doesn't like it when provided the asked arguments.(Also refer to the comment above that line)

Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. See a few additional comments below

packages/sitecore-jss-rendering-host/src/devServer.ts Outdated Show resolved Hide resolved
packages/sitecore-jss-rendering-host/src/devServer.ts Outdated Show resolved Hide resolved
packages/sitecore-jss-rendering-host/src/devServer.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! 👍

@illiakovalenko illiakovalenko merged commit 041a6c5 into dev Feb 7, 2023
@illiakovalenko illiakovalenko deleted the feature/513290-other-package-uprgade branch February 7, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants