-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Other packages] Upgrade 3rd party dependencies #1321
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work on upgrades! Please, see my comments below
And I wanna ask you to provide reasons (add them to the description of PR) why some primary and vulnerable dependencies were not upgraded, like:
- [sitecore-jss-rendering-host] webpack-dev-server
- etc. if something else is skipped
packages/sitecore-jss-dev-tools/src/resolve-scjssconfig.test.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-dev-tools/src/resolve-scjssconfig.test.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-rendering-host/src/renderingHostServer.ts
Outdated
Show resolved
Hide resolved
Most of the packages which are not upgraded or not upgraded to the latest version is because they migrated to For Similarly for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. See a few additional comments below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! 👍
Upgraded 3rd party dependencies for:
Description / Motivation
Testing Details
Types of changes