-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular update to version 14 #1285
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gular-update-ex # Conflicts: # yarn.lock
illiakovalenko
requested changes
Jan 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! See review comments below and some things to mention:
- Check packages by using
npm i
,sitecore-jss-angular
can't be installed npm run coverage
is not working forsitecore-jss-angular
- Coverage report should be logged to the console as it was before
- Unit tests coverage is not included in Azure pipelines coverage report, but it should be there as it was before
- Check
package.json
files and use latest version everywhere. (^ uses the latest, but anyway it should be explicitly set) - There is no way to import something from
sitecore-jss-angular
if you are using script, it's an issue and we will need to maintain both places (cause you added duplicate)
packages/create-sitecore-jss/src/templates/angular/scripts/constants.json
Outdated
Show resolved
Hide resolved
illiakovalenko
requested changes
Jan 17, 2023
packages/create-sitecore-jss/src/templates/angular/package.json
Outdated
Show resolved
Hide resolved
illiakovalenko
approved these changes
Jan 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 👍
…gular-update-ex # Conflicts: # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for Angular package and sample app to version 14
Description / Motivation
JSS will now use the LTS version of Angular. This comes with some side effects, considering the changes introduced in Angular 13 (https://blog.angular.io/angular-v13-is-now-available-cce66f7bc296)
Types of changes