Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra unit test coverage for react package #1258

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Extra unit test coverage for react package #1258

merged 1 commit into from
Dec 14, 2022

Conversation

art-alexeyenko
Copy link
Contributor

Description / Motivation

This PR does a few things:

  • modify nyc coverage rules to have a more accurate coverage statistics
  • add more tests for increased coverage, where tests are missing and make sense

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team December 13, 2022 20:30
ambrauer
ambrauer approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ambrauer ambrauer merged commit 2e189ca into dev Dec 14, 2022
@ambrauer ambrauer deleted the feature/react-package-unit-test-coverage branch December 14, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@art-alexeyenko @ambrauer