Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Next.js][React] Link component does not add anchor to the internal links #1228

Merged
merged 6 commits into from
Nov 4, 2022
Merged

[Next.js][React] Link component does not add anchor to the internal links #1228

merged 6 commits into from
Nov 4, 2022

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Nov 2, 2022 •
edited
Loading

Add support for anchor attribute for:

  • sitecore-jss-react
  • sitecore-jss-nextjs

Description / Motivation

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania changed the title [Next.js][React] Link component does not add anchor to the internal links [Hotfix] Link component does not add anchor to the internal links Nov 2, 2022
@addy-pathania addy-pathania requested a review from a team November 2, 2022 22:56
@addy-pathania addy-pathania changed the title [Hotfix] Link component does not add anchor to the internal links [Next.js][React] Link component does not add anchor to the internal links Nov 2, 2022
illiakovalenko
illiakovalenko requested changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, update CHANGELOG, otherwise looks good
And I guess that you don't need to cancel azure pipelines build when you are in the PR, you need to that when you merged your changes to release branch

@addy-pathania
Copy link
Contributor Author

Please, update CHANGELOG, otherwise looks good And I guess that you don't need to cancel azure pipelines build when you are in the PR, you need to that when you merged your changes to release branch

I will do that.
I didn't cancel the pipelines. One of the test is failing. I am looking into that.

ambrauer
ambrauer reviewed Nov 4, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
ambrauer
ambrauer approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment about CHANGELOG, otherwise looks good 👍

@addy-pathania addy-pathania merged commit ebdec4a into release/19.0.0 Nov 4, 2022
@addy-pathania addy-pathania deleted the hotfix/anchor-tag branch November 4, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko requested changes

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@addy-pathania @ambrauer @illiakovalenko