Sitecore-first component deployment fixes #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes `jss deploy component` having invalid casing on <Name> param, which broke it because the code expected <name> instead (maybe a new thing in a yargs update, used to work fine) - Fixes `jss deploy component` creating a datasource template even if `--fields` was not passed. It should be usable to create datasource-less components as well. - `jss manifest` will now stop if a template fails validation, instead of ignoring it and continuing without that template
aweber1
approved these changes
Jan 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jss deploy componenthaving invalid casing on<Name>param, which broke it because the code expected<name>instead (maybe a new thing in a yargs update, used to work fine)jss deploy componentcreating a datasource template even if--fieldswas not passed. It should be usable to create datasource-less components as well. This is a breaking change but breaks it in the direction of sanity.jss manifestwill now stop if a template fails validation, instead of ignoring it and continuing without that templateTypes of changes