Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating next to 12.2.4 - and reintroducing babel to avoid swc errors #1124

Merged
merged 2 commits into from
Aug 10, 2022

Conversation

art-alexeyenko
Copy link
Contributor

Nextjs 12.2.4 fixes some issues - but reintroduces swc exception that happens in containers. This PR reintroduces babelrc file to avoid it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

addy-pathania
addy-pathania approved these changes Aug 9, 2022
Copy link
Contributor

@addy-pathania addy-pathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the yarn.lock file. CI build failed.

Copy link
Contributor

@addy-pathania addy-pathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@addy-pathania addy-pathania merged commit 7821e14 into dev Aug 10, 2022
@addy-pathania addy-pathania deleted the bug/546482-swc-exception branch August 10, 2022 19:49
@@ -32,7 +32,7 @@
"@sitecore-jss/sitecore-jss-nextjs": "^21.0.0-canary",
"graphql": "~15.8.0",
"graphql-tag": "^2.11.0",
"next": "^12.2.2",
"next": "^12.2.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12.2.5 has been released 12d ago ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants