Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paginated results retrieval in sitemap paths service #1112

Conversation

art-alexeyenko
Copy link
Contributor

Description / Motivation

This fixes some irregularities with promises in graphql-sitemap-service, so that paginated path results are retrieved properly.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ambrauer ambrauer merged commit d737352 into dev Jul 20, 2022
@ambrauer ambrauer deleted the bug/537719-gql-sitemap-does-not-return-all-results-with-multiple-langs branch July 20, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants