GraphQL sitemap now parses personalize data from site queries #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s it into returned paths
illiakovalenko
requested changes
May 5, 2022
packages/sitecore-jss-nextjs/src/services/graphql-sitemap-service.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/services/graphql-sitemap-service.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/services/graphql-sitemap-service.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/services/graphql-sitemap-service.test.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/services/graphql-sitemap-service.test.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/services/graphql-sitemap-service.test.ts
Outdated
Show resolved
Hide resolved
|
In the PBI I see that we should use |
packages/sitecore-jss-nextjs/src/services/graphql-sitemap-service.ts
Outdated
Show resolved
Hide resolved
ambrauer
reviewed
May 5, 2022
packages/sitecore-jss-nextjs/src/services/graphql-sitemap-service.ts
Outdated
Show resolved
Hide resolved
…ure/528677-personalize-sitemap
… + addressing comments, refactor
ambrauer
suggested changes
May 11, 2022
packages/sitecore-jss-nextjs/src/services/graphql-sitemap-service.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/services/graphql-sitemap-service.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/services/graphql-sitemap-service.ts
Outdated
Show resolved
Hide resolved
ambrauer
approved these changes
May 11, 2022
illiakovalenko
requested changes
May 12, 2022
packages/sitecore-jss-nextjs/src/services/graphql-sitemap-service.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/testData/sitemapPersonalizeQueryResult.json
Outdated
Show resolved
Hide resolved
illiakovalenko
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for personalize variants data into GraphQL sitemap service in nextjs project
Description / Motivation
Site routes returned by GraphQL can have variants data included. Variants will now be included in site paths, when provided.
Testing Details
One unit test added
Types of changes