Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tsconfig.json updates #1000

Merged
merged 3 commits into from
Apr 29, 2022
Merged

tsconfig.json updates #1000

merged 3 commits into from
Apr 29, 2022

Conversation

sc-nikolaoslazaridis
Copy link
Contributor

@sc-nikolaoslazaridis sc-nikolaoslazaridis commented Apr 27, 2022 •
edited by illiakovalenko
Loading

Description / Motivation

  1. Created a tsconfig.json file at the root level that has all shared options used in packages.
  2. Added noImplicitThis, noImplicitAny, noUnusedLocals, allowSyntheticDefaultImports to this file.
  3. Added noImplicitAny, noImplicitReturns, noImplicitThis, noUnusedLocals, noUnusedParameters to samples that have tsconfig file.
  4. Deleted unused testData folder in sitecore-jss-dev-tools/src/manifest.
  5. Fixed ts errors caused by the changes.

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@sc-nikolaoslazaridis
Created a tsconfig.json file at root level that has all shared option…
aa6ca63 
…s used in packages. Added noImplicitThis, noImplicitAny, noUnusedLocals and allowSyntheticDefaultImports to this file. Added noImplicitAny, noImplicitReturns, noImplicitThis, noUnusedLocals and noUnusedParameters to samples that have tsconfig file. Fixed ts errors caused by the changes. Deleted unused testData folder in sitecore-jss-dev-tools/src/manifest.
@sc-nikolaoslazaridis sc-nikolaoslazaridis requested a review from a team April 27, 2022 13:16
illiakovalenko
illiakovalenko approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@illiakovalenko illiakovalenko merged commit a0e1a7a into Sitecore:dev Apr 29, 2022
@sc-nikolaoslazaridis sc-nikolaoslazaridis deleted the bugfix/445597-tsconfig-updates branch May 9, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sc-nikolaoslazaridis @illiakovalenko