Minor fixes

SirWaithaka · Nov 15, 2020 · 40b2414 · 40b2414
1 parent 9dfa8de
commit 40b2414
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/app/account/params.go b/app/account/params.go
diff --git a/app/ports/params.go b/app/ports/params.go
diff --git a/app/ports/transactor.go b/app/ports/transactor.go
@@ -1,5 +1,9 @@
 package ports
 
+/**
+	ports is definitely not the best name for this package.
+ */
+
 import (
 	"simple-mpesa/app/customer"
 	"simple-mpesa/app/models"
@@ -8,6 +12,11 @@ import (
 	"github.com/gofrs/uuid"
 )
 
+// TransactorPort is not a good name. Its function is to expose an interface to the application layer that it
+// can use to perform transactions.
+//
+// To keep the Transaction context clean from a dependency of the agent, merchant and subscriber contexts,
+// i chose to create this port separately.
 type TransactorPort interface {
 	Deposit(depositor models.TxnCustomer, customerNumber string, customerType models.UserType, amount models.Shillings) error
 	Transfer(source models.TxnCustomer, destAccNumber string, destCustomerType models.UserType, amount models.Shillings) error

diff --git a/app/storage/postgres/migrations.go b/app/storage/postgres/migrations.go
@@ -16,7 +16,6 @@ func Migrate(database *storage.Database) {
 		models.Agent{},
 		models.Merchant{},
 		models.Subscriber{},
-		models.User{},
 		models.Account{},
 		models.Transaction{},
 		statement.Statement{},