Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete profileBuild #205

Closed
wants to merge 3 commits into from

Conversation

haruki7049
Copy link

@haruki7049 haruki7049 commented Nov 17, 2024

This PR deletes profileBuild option.

I don't know the context in /nix/profileOverlays.nix, so I simply deleted it. Review this PR if this choice has a problem.

@haruki7049 haruki7049 marked this pull request as draft November 20, 2024 06:33
@haruki7049 haruki7049 changed the title Delete profileBuild in default.nix Delete profileBuild Nov 20, 2024
@haruki7049 haruki7049 marked this pull request as ready for review November 20, 2024 06:48
@georgewsinger
Copy link
Collaborator

We use profile builds when performance testing Simula. If it's broken, it's better to fix it than delete the feature all together.

@haruki7049
Copy link
Author

Humm... OK. I understood a little. I close this PR and I want to listen to your description of /nix/profileOverlays.nix in #204. Either way, no /nix/profileOverlays.nix is too bad...

@haruki7049 haruki7049 closed this Nov 20, 2024
@haruki7049 haruki7049 deleted the fix-profile-overlay branch November 20, 2024 08:07
@haruki7049 haruki7049 restored the fix-profile-overlay branch November 23, 2024 03:27
@haruki7049 haruki7049 deleted the fix-profile-overlay branch November 25, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/nix/profileOverlays.nix doesn't exists on master branch
2 participants