Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for lilting provided files by paths #1

Conversation

dshikulin-mwb
Copy link

  • Fixed "Unknown option '--target'". Option was passed to swiftlint tool even after extracting that option to determine targets' paths.
  • Backwards compatibility
    • pass arguments without defining targets to run linting on all targets with passed arguments.
    • pass arguments and '--target' option to lint provided targets with provided arguments.
  • New: pass arguments and paths without '--target' option to run linting only on these paths with passed arguments.

- Fixed "Unknown option '--target'". Option was passed to swiftlint command even after extracting that option to determine targets' paths
- Backwards compatibility
  - pass arguments without defining targets to run linting on all targets with passed arguments.
  - pass arguments and '--target' option to lint provided targets with provided arguments.
- New: pass arguments and paths without '--target' option to run linting only on these paths with passed arguments.
@dshikulin-mwb dshikulin-mwb deleted the dshikulin/pass-file-paths branch August 16, 2024 15:48
@dshikulin-mwb dshikulin-mwb restored the dshikulin/pass-file-paths branch August 16, 2024 15:50
@dshikulin-mwb
Copy link
Author

Sorry, created it by accident, you can delete it.
I plan to propose same to main repository.

@JayShortway
Copy link

@dshikulin-mwb Are you still planning on proposing this to the main repository? 🙂 We're currently running into the issue where the --target option is passed to swiftlint by the SwiftLintCommandPlugin.

@dshikulin-mwb
Copy link
Author

@JayShortway Yep, will probably suggest these changes next week to main repo.

@JayShortway
Copy link

@dshikulin-mwb Alright, thank you! Looking forward to it.

@dshikulin-mwb
Copy link
Author

dshikulin-mwb commented Dec 2, 2024

@JayShortway
It was not a week, but the PR was opened :)

Probably the fixes that you were waiting for were already fixed in realm/SwiftLint@c784adc

In case if some one is interested in using CommandPlugin as CLI to lint only several given files, here is the PR:
realm/SwiftLint#5879

@JayShortway
Copy link

@dshikulin-mwb Haha no worries! I'm glad it's up 😄

Thanks for pointing me to realm/SwiftLint@c784adc. That indeed seems to be what we need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants