Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting environment variables change. #63

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

zivy
Copy link
Member

@zivy zivy commented Dec 2, 2024

The devtools install_github command no longer supports the "args" parameter. The same effect is achieved by setting the "configure.vars" parameter.

@blowekamp
Copy link
Member

I don't see any CI that ran. The main workflow was marked disabled, please force push to see if it triggers it now.

@richardbeare
Copy link
Collaborator

I've confirmed that the modified instructions work on the mac. It seems that the CI workflow already used the configure.vars option.

Also, it may be nice to change devtools::install_github to remotes::install_github. The package structure has been refactored over the years and the install from remote places function now live in the remotes package.

The remotes package was split from the larger devtools package and is
now the recommended package to use for installation from git
repositories. This updates the documentation and the GitHub workflow.
@zivy zivy force-pushed the updateInstructions branch from 799dcdf to 938d6db Compare December 4, 2024 14:22
@zivy
Copy link
Member Author

zivy commented Dec 4, 2024

Updated instructions and GitHub workflow to use the remotes package and force pushed.

Copy link
Member

@blowekamp blowekamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI passed!

@zivy zivy merged commit 32c8f91 into SimpleITK:main Dec 4, 2024
1 check passed
@zivy zivy deleted the updateInstructions branch December 4, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants