-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bulk column transformations and data cleansing gems #448
Bulk column transformations and data cleansing gems #448
Conversation
outline docs without example screenshots
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
### Remove date columns with an expression | ||
|
||
Using the same example, you can accomplish the same task with the **Select via expression** method by inputting the the expression `column_type NOT IN ('date', 'timestamp')`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the Select via expression the same kind of method used in the Bulk Column Rename example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question! I asked the same to Ashish. They are not the same. For both of them, you only have access to a limited number of variables (which actually are included in the UI for dynamic select). Ashish asked me to open an Asana ticket to ask him to include the available variables for bulk column rename.
Looks good, I just had a question about the example you used. Also, do you think stylistically if we should avoid using periods at the end of the Description column lines and unordered list items? https://developers.google.com/style/lists#capitalization-and-end-punctuation |
Actually, the unordered list would be fine in this case, but maybe not the Description lines. WDYT? |
Good point! Maybe we can adopt the same logic as the list style that you linked. In other words, use periods in tables if the sentence includes a verb, but otherwise don't use a period. |
To do: Integrate version requirement info when Ashish gets back to me. I think we can merge this first, and add that later.