Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk column transformations and data cleansing gems #448

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

kathweinschenkprophecy
Copy link
Collaborator

@kathweinschenkprophecy kathweinschenkprophecy commented Nov 25, 2024

To do: Integrate version requirement info when Ashish gets back to me. I think we can merge this first, and add that later.

outline docs without example screenshots
Copy link
Collaborator

@alexanderahn alexanderahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


### Remove date columns with an expression

Using the same example, you can accomplish the same task with the **Select via expression** method by inputting the the expression `column_type NOT IN ('date', 'timestamp')`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the Select via expression the same kind of method used in the Bulk Column Rename example?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question! I asked the same to Ashish. They are not the same. For both of them, you only have access to a limited number of variables (which actually are included in the UI for dynamic select). Ashish asked me to open an Asana ticket to ask him to include the available variables for bulk column rename.
image

@alexanderahn
Copy link
Collaborator

Looks good, I just had a question about the example you used.

Also, do you think stylistically if we should avoid using periods at the end of the Description column lines and unordered list items? https://developers.google.com/style/lists#capitalization-and-end-punctuation

@alexanderahn
Copy link
Collaborator

Looks good, I just had a question about the example you used.

Also, do you think stylistically if we should avoid using periods at the end of the Description column lines and unordered list items? https://developers.google.com/style/lists#capitalization-and-end-punctuation

Actually, the unordered list would be fine in this case, but maybe not the Description lines. WDYT?

@kathweinschenkprophecy
Copy link
Collaborator Author

Looks good, I just had a question about the example you used.

Also, do you think stylistically if we should avoid using periods at the end of the Description column lines and unordered list items? https://developers.google.com/style/lists#capitalization-and-end-punctuation

Good point! Maybe we can adopt the same logic as the list style that you linked. In other words, use periods in tables if the sentence includes a verb, but otherwise don't use a period.

@alexanderahn alexanderahn self-requested a review November 27, 2024 15:54
@kathweinschenkprophecy kathweinschenkprophecy merged commit f258943 into main Nov 27, 2024
1 check passed
@kathweinschenkprophecy kathweinschenkprophecy deleted the bulk-column-transforms-and-cleansing branch November 27, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants