Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disposeBackgroundOnTap or something #237

Closed
sed1ka opened this issue Jun 28, 2022 · 0 comments · Fixed by #252
Closed

Add disposeBackgroundOnTap or something #237

sed1ka opened this issue Jun 28, 2022 · 0 comments · Fixed by #252

Comments

@sed1ka
Copy link

sed1ka commented Jun 28, 2022

Is your feature request related to a problem? Please describe.
In the flow of my app, before running the showcase, I create a showDialog to alert the user that there is a new feature. There are two buttons 'explore' and 'ignore', if the user selects the 'explore' button, then ShowCase will run.

I used Showcase.withWidget to add custom "Next" and "Skip" buttons in tooltips

  • 'Next' button, serves to go to the next showcase
  • 'Skip' button, serves to close all showcases.

Describe the solution you'd like
The problem is, that everything I applied above is useless because the showcase can be closed by pressing the background overlay. There is a disposeOnTap function, but it only works for tooltips or container in the Showcase.withWidget parameter, not with background overlays. Please add a parameter like disposeBackgroundOnTap or something

@vatsaltanna vatsaltanna linked a pull request Aug 1, 2022 that will close this issue
vatsaltanna pushed a commit that referenced this issue Aug 1, 2022
* ✨ #240, #244 Disable overlayClick

* Update Readme.md

Co-authored-by: Mehul Kabaria <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant