Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTPView implemented with three types #1

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

priyal-p-simformsolutions
Copy link
Collaborator

OTPView implemented with three types

  • box type
  • underline
  • plain

primaryVariant = Purple700,
secondary = Teal200

/* Other default colors to override
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unnecessary code

fontWeight = FontWeight.Normal,
fontSize = 16.sp
)
/* Other default text styles to override
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unnecessary code

)

@Composable
fun MyApplicationTheme(darkTheme: Boolean = isSystemInDarkTheme(), content: @Composable () -> Unit) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add .gif in your changes for the behavior

@mobile-simformsolutions mobile-simformsolutions force-pushed the feature/otpview branch 4 times, most recently from bb24f8b to c68aa52 Compare July 6, 2022 06:59
@yashwantgowla-simform
Copy link
Collaborator

Please add toolbar/title for each gif. Let's say example is Underline star so keep title for the same in the activity

```kotlin
OtpView(
otpText = otpValue,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add attribute section below the code snippet.

Different type of arc OTPViews. Easy to use and configure your own View and character of OTP using all the attributes.

# Features
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add more features with proper description.

README.md Outdated

```
Copyright 2021 Simform Solutions
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright 2022*

README.md Outdated
## How to use the library?
- Using Compose
Just use the `OtpView` composable where you need to display the view like.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to make it more understandable

Next in your code create OtpView composable function like this:
```kotlin
fun OtpView(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add few attributes for otpCount and strokeColor in OtpView composable function.

@priyal-p-simformsolutions priyal-p-simformsolutions force-pushed the feature/otpview branch 8 times, most recently from 08c5920 to e633128 Compare July 22, 2022 13:54
@yashwantgowla-simform yashwantgowla-simform merged commit 19ecc91 into develop Jul 25, 2022
@yashwantgowla-simform yashwantgowla-simform deleted the feature/otpview branch July 25, 2022 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants