Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix svZeroDVisualization tests #134

Merged
merged 10 commits into from
Oct 13, 2024

Conversation

menon-karthik
Copy link
Member

@menon-karthik menon-karthik commented Oct 7, 2024

Current situation

Closes #133
The current tests for svZeroDVisualization are failing because the method used to compare generated with expected dot files is sensitive to file timestamps, spaces, etc.

Release Notes

Fixed the testing so that the generated and expected dot files are compared line-by-line.
Also fixed a couple of typos in the documentation.

Documentation

N/A

Testing

This fixes the testing.

Code of Conduct & Contributing Guidelines

@menon-karthik menon-karthik added the bug Something isn't working label Oct 7, 2024
@menon-karthik menon-karthik self-assigned this Oct 7, 2024
@menon-karthik menon-karthik marked this pull request as ready for review October 11, 2024 22:09
Copy link
Contributor

@emilinmathew emilinmathew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to tests/test_dirgraph.py look good, particularly the logic for comparing the generated and expected dot files. The use of readlines() ensures a clean comparison between the two files. Thanks for fixing the bug!

@menon-karthik menon-karthik merged commit ad67a5a into SimVascular:master Oct 13, 2024
10 checks passed
@menon-karthik menon-karthik deleted the fix_viz_test branch October 13, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The tests for svZeroDVisualization are failing
2 participants