Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made all code pep8 conformant #23

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AltraMage
Copy link

Reformated all code to be pep8 conformant; Includes changing testing date to None, and moving ics to credentials

Reformated all code to be pep8 conformant; Includes changing testing date to None, and moving ics to credentials
@app.route("/api/cal")
def cal():
return parse_calendar.parse_all_calendars()

#! TESTING LINE
# TESTING LINE
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not be indented to the first level?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much of a muchness, lets have it indented then

@app.route("/api/menu")
def menu():
return parse_menu.main()

#! TESTING LINE
# TESTING LINE
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use the #! with the Better Comments VSC plugin to make important items stand out
image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, I'll do that in future

@app.route("/api/menu")
def menu():
return parse_menu.main()

#! TESTING LINE
# TESTING LINE
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# TESTING LINE
# ! TESTING LINE

@app.route("/api/cal")
def cal():
return parse_calendar.parse_all_calendars()

#! TESTING LINE
# TESTING LINE
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# TESTING LINE
# ! TESTING LINE

}

quote_url = "https://zenquotes.io/api/today"


menu_sheet = ""
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
menu_sheet = ""
menu_sheet = ""

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the change here, I think I'm missing something

main.py Dismissed Show dismissed Hide dismissed
Copy link
Author

@AltraMage AltraMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, seems all good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants