Add customizable TRAMP method for container connections across shells #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Silex
reviewed
Nov 8, 2024
|
Thanks looks neat. Just address the comment and I'll merge. |
- Introduced `docker-container-tramp-method` to allow selection of TRAMP method, enabling compatibility with Docker or Podman. - Refactored all Emacs shells to use the new variable for container connections, improving flexibility and cross-tool support.
|
Fixed, rebased and force pushed to keep the history clean. |
|
Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there!
I've recently covered
docker.elin a blog post (https://www.rahuljuliato.com/posts/emacs-docker-podman), and people got really exited about it.One """limitation""" is that on some systems I can only use
podmanand even customizingdocker-commandanddocker-compose-commandto 'podman' and 'podman-compose' there are still limitations, most noticeable with the 'shell' commands.So I stepped ahead and extracted the
/docker:prefixes into into a customizable variable, we can now use podman with thedocker-container.elsub-module.I tested on
eshell,shell,vtermandeat.This commit:
Introduced
docker-container-tramp-methodto allow selection of TRAMP method, enabling compatibility with Docker or Podman.Refactored all Emacs shells to use the new variable for container connections, improving flexibility and cross-tool support.