Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMGs to templates #419

Open
wants to merge 4 commits into
base: unstable
Choose a base branch
from
Open

Conversation

wersal454
Copy link

What type of PR is this?

  1. Bug
  2. Change
  3. Enhancement
  4. Miscellaneous

What have you changed and why?

Information:

replace rifles with SMGs in [selectRandom ["rifles", "carbines"]] call _fnc_setPrimary;
and
in some cases add SMGs to [selectRandom ["rifles", "carbines"]] call _fnc_setPrimary;

Please specify which Issue this PR Resolves (If Applicable).

"This PR closes #XXXX!"

Please verify the following.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

How can the changes be tested?

Steps:


Notes:

@stutpip123
Copy link
Collaborator

its trying to merge into stable, should be directed into unstable.

have you verified that every single template you have changed actually uses SMGs, cause if not then its liable to break and pointless to change.
as the PR will need redoing anyway to point to unstable, perhaps start smaller focusing on templates where it makes the biggest difference and most logical usage of SMGs, don't just do it to all of them

@wersal454 wersal454 changed the base branch from stable to unstable December 9, 2024 20:59
@wersal454
Copy link
Author

its trying to merge into stable, should be directed into unstable.

have you verified that every single template you have changed actually uses SMGs, cause if not then its liable to break and pointless to change. as the PR will need redoing anyway to point to unstable, perhaps start smaller focusing on templates where it makes the biggest difference and most logical usage of SMGs, don't just do it to all of them

won't be needing to redoing the pr to switch into unstable, you simply change the base
As for verification, I'll take a look if every template has SMG's or not

@wersal454
Copy link
Author

after the first pass, noticed that I missed a couple of templates, added changes to those
Checked every template, seems every affected template has them

  • some RHS and 3CB US templates don't have any SMGs AT ALL, so removed changes in them @SilenceIsFatto police still uses smgs in such templates(sometimes only SMGs) and it doesn't break(seemingly)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants