Vehicle turret magazine reload port #410
Conversation
|
couldn't find where to put a disable/enable parametr, probably could add it at the beginning of each sqf file |
|
|
||
| class reload_repack_turret_magazines { | ||
| file = QPATHTOFOLDER(Scripts\RRTurretMagazines\scripts); | ||
| class postInit {}; | ||
| class reloadTurret {}; | ||
| class monitorMagazines {}; | ||
| }; |
There was a problem hiding this comment.
Doesn't this class postInit overwrite the original A3A_fnc_postInit? That would be a very critical issue
If it's going to be called by execVM then you don't actually need to define it here anyway
| private _ammoThisMag = selectMin [_fullCount, _totalAmmo]; | ||
| _magsAdd pushBack [_currentMagazine, _turretPath, _ammoThisMag]; | ||
| _totalAmmo = _totalAmmo - _ammoThisMag; | ||
| _message = _message + str _ammoThisMag + ([", ", ""] select (_i == _magsCount)); |
There was a problem hiding this comment.
[", ", ""]Is this not an issue?
There was a problem hiding this comment.
it works, so ...no? I mean, you tried this PR right?
There was a problem hiding this comment.
I tried many other pulls and they "worked", until they didn't
Literally the point of reviewing, I see a syntax issue so I point it out?
There was a problem hiding this comment.
iirc, at first it was [",", ""], I added additional space after comma so created text would look better [", ", ""]
A3A/addons/core/Scripts/RRTurretMagazines/scripts/fn_reloadTurret.sqf
Outdated
Show resolved
Hide resolved
A3A/addons/core/Scripts/RRTurretMagazines/scripts/fn_monitorMagazines.sqf
Outdated
Show resolved
Hide resolved
…ret.sqf Co-authored-by: Silence <[email protected]>
…gazines.sqf Co-authored-by: Silence <[email protected]>
What type of PR is this?
What have you changed and why?
Information:
Ported + translated this mod/script https://github.com/ampersand38/reload-repack-turret-magazines , because it seems usefull
Please specify which Issue this PR Resolves (If Applicable).
"This PR closes #XXXX!"
Please verify the following.
Is further testing or are further changes required?
How can the changes be tested?
Steps:
Notes: