HQ vehicle store UI rework #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might need to make a port to community version to maybe receive help with this one |
|
done |
SilenceIsFatto
requested changes
Oct 27, 2024
SilenceIsFatto
approved these changes
Nov 23, 2024
SilenceIsFatto
requested changes
Nov 26, 2024
There was a problem hiding this comment.
The UI is nice to use, very good
I think that the stringtables should be updated to capitalize the vehicle type, e.g: Civilian Cars rather than Civilian cars. It's minor but this way it will maintain visual consistency with the arms dealer
Also there's a minor issue with the CfgFunctions, it's a simple fix. See the review
Co-authored-by: Silence <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What have you changed and why?
Information:
Attempt at adding more filtering into HQ vehicle store
Please specify which Issue this PR Resolves (If Applicable).
"This PR closes #XXXX!"
Please verify the following.
Is further testing or are further changes required?
How can the changes be tested?
Steps:
Notes:
not worki at the moment (13.07.2024)