Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reaction Forces Templates #149

Merged
merged 6 commits into from
Apr 5, 2024
Merged

Reaction Forces Templates #149

merged 6 commits into from
Apr 5, 2024

Conversation

SilenceIsFatto
Copy link
Owner

@SilenceIsFatto SilenceIsFatto commented Mar 30, 2024

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

Information:
Added Reaction Forces templates from Community PR 3185 (Tiny-DM)

Please specify which Issue this PR Resolves.

closes #XXXX

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

How can the changes be tested?

Steps:
Load RF CDLC;
Load one of the compatible RF templates (Most of the vanilla ones);
Enable RF CDLC in additional content;
Ensure RF assets are being used


Notes:

@SilenceIsFatto SilenceIsFatto added enhancement New feature or request faction/template A new faction or template labels Mar 30, 2024
@wersal454
Copy link

Don't forget about elite loadouts, probably can copy special forces stuff, except silencers for weapons, also I don't see new sniper rifle and "deagle"(deagle is debatable, but Special forces or elites might use it)

@Tiny-DM
Copy link

Tiny-DM commented Apr 1, 2024

The new sniper rifle was not added, as it replaces the rebels' normal starting SMGs. It was considered to give the weapon to DMRs/Snipers, but a 5.56 round does not carry velocity nearly far enough to work at all as a sniper weapon, and giving a DMR a bolt-action weapon, especially chambered in a caliber as small as 5.56, was considered but not added. There is most likely precedent in other templates, but vanilla armor is good enough to render the rifle only effective enough for the rebels.

Deagles were not added primarily because semi/auto Glocks are typically a much more lore accurate and realistic weapon for soldiers to use, and also because I didn't want to have to deal with trying to give them a special handgun for consistency.

Also, make sure you pull the WS_Civ faction from the templates list, as that appears to be a template not present in this version of Antistasi.

Copy link

@wersal454 wersal454 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In vanilla civ. I missed that

if (_hasLawsOfWar) then {
_civMedical append ["C_Van_02_medevac_F", 0.3];
};

@SilenceIsFatto
Copy link
Owner Author

The new sniper rifle was not added, as it replaces the rebels' normal starting SMGs. It was considered to give the weapon to DMRs/Snipers, but a 5.56 round does not carry velocity nearly far enough to work at all as a sniper weapon, and giving a DMR a bolt-action weapon, especially chambered in a caliber as small as 5.56, was considered but not added. There is most likely precedent in other templates, but vanilla armor is good enough to render the rifle only effective enough for the rebels.

Deagles were not added primarily because semi/auto Glocks are typically a much more lore accurate and realistic weapon for soldiers to use, and also because I didn't want to have to deal with trying to give them a special handgun for consistency.

Also, make sure you pull the WS_Civ faction from the templates list, as that appears to be a template not present in this version of Antistasi.

Pretty sure I added WS_Civ in this PR. We seem to be missing quite a lot of the WS templates, I assume they were added after we forked Plus and have been forgotten in subsequent updates.
Thanks for the heads up

@wersal454
Copy link

Also don't forget about, rivals

@SilenceIsFatto
Copy link
Owner Author

Rivals added, ideally want someone else to confirm templates are working with RF cdlc enabled

@wersal454
Copy link

Seems to work for the most part. No error messages. Black market stuff works. Some small issues + missing some stuff.

@SilenceIsFatto SilenceIsFatto removed the enhancement New feature or request label Apr 4, 2024
@SilenceIsFatto SilenceIsFatto merged commit 35c82a9 into unstable Apr 5, 2024
@SilenceIsFatto SilenceIsFatto deleted the rf-templates branch September 25, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
faction/template A new faction or template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants