Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix(backend): Fix month credit calculation on December #8851

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

majdyz
Copy link
Contributor

@majdyz majdyz commented Dec 2, 2024

When calculating the next month, we are not rolling the month number causing an error on credits.

Changes πŸ—οΈ

Add modulo while calculating next month.

Checklist πŸ“‹

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • ...
Example test plan
  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

For configuration changes:

  • .env.example is updated or already compatible with my changes
  • docker-compose.yml is updated or already compatible with my changes
  • I have included a list of my configuration changes in the PR description (under Changes)
Examples of configuration changes
  • Changing ports
  • Adding new services that need to communicate with each other
  • Secrets or environment variable changes
  • New or infrastructure changes such as databases

@majdyz majdyz requested a review from a team as a code owner December 2, 2024 01:45
@majdyz majdyz requested review from Torantulino and aarushik93 and removed request for a team December 2, 2024 01:45
Copy link

qodo-merge-pro bot commented Dec 2, 2024

PR Reviewer Guide πŸ”

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 πŸ”΅βšͺβšͺβšͺβšͺ
πŸ§ͺΒ No relevant tests
πŸ”’Β No security concerns identified
⚑ Recommended focus areas for review

Edge Case
Verify that the month rollover logic works correctly when transitioning from December to January, including handling of the year change

@github-actions github-actions bot added platform/backend AutoGPT Platform - Back end size/s labels Dec 2, 2024
Copy link

netlify bot commented Dec 2, 2024

βœ… Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
πŸ”¨ Latest commit 86457bf
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/674d1148d3d67500084beb4a

Copy link

netlify bot commented Dec 2, 2024

βœ… Deploy Preview for auto-gpt-docs ready!

Name Link
πŸ”¨ Latest commit 86457bf
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/674d1148809b080008a14ebb
😎 Deploy Preview https://deploy-preview-8851--auto-gpt-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@majdyz
Copy link
Contributor Author

majdyz commented Dec 2, 2024

I'm going to merge this directly since it breaks the CI & the running system.

@majdyz majdyz merged commit d26105d into dev Dec 2, 2024
17 of 19 checks passed
@majdyz majdyz deleted the zamilmajdy/fix-month-credit-calculation branch December 2, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant