Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blocks): Add Exa API Blocks #8835

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
Open

Conversation

aarushik93
Copy link
Contributor

@aarushik93 aarushik93 commented Nov 27, 2024

Adding Exa API blocks because it does very cool search and web scrapping

Changes πŸ—οΈ

Adding Exa API blocks:
Search

Added a new calendar and time input

Added _auth.py for Exa API too.

Checklist πŸ“‹

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • ...
Example test plan
  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

For configuration changes:

  • .env.example is updated or already compatible with my changes
  • docker-compose.yml is updated or already compatible with my changes
  • I have included a list of my configuration changes in the PR description (under Changes)
Examples of configuration changes
  • Changing ports
  • Adding new services that need to communicate with each other
  • Secrets or environment variable changes
  • New or infrastructure changes such as databases

@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end platform/blocks size/l labels Nov 27, 2024
Copy link

netlify bot commented Nov 27, 2024

βœ… Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
πŸ”¨ Latest commit 26fb5ea
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/674db22aecdf7b0008459941

Copy link

netlify bot commented Nov 27, 2024

βœ… Deploy Preview for auto-gpt-docs ready!

Name Link
πŸ”¨ Latest commit 26fb5ea
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/674db22a9549c300085e75a2
😎 Deploy Preview https://deploy-preview-8835--auto-gpt-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added size/xl and removed size/l labels Nov 27, 2024
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Nov 29, 2024
Copy link
Contributor

Conflicts have been resolved! πŸŽ‰ A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Nov 29, 2024
@aarushik93 aarushik93 marked this pull request as ready for review November 29, 2024 17:46
@aarushik93 aarushik93 requested a review from a team as a code owner November 29, 2024 17:46
@aarushik93 aarushik93 requested review from Swiftyos and Torantulino and removed request for a team November 29, 2024 17:46
Copy link

PR Reviewer Guide πŸ”

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 πŸ”΅πŸ”΅πŸ”΅βšͺβšͺ
πŸ§ͺΒ No relevant tests
πŸ”’Β Security concerns

API Key Exposure:
The Exa API key is sent in request headers. While using HTTPS, ensure the requests are not logged or cached in a way that could expose the API key. Also verify that error responses don't include the API key in error messages or logs.

⚑ Recommended focus areas for review

Error Handling
The error handling in the search block is too generic and may hide important error details. Consider handling specific error types separately and providing more informative error messages.

Input Validation
The block accepts several datetime fields but there's no validation to ensure end dates are after start dates, or that dates are within reasonable ranges.

State Management
The time input state is managed separately from the date state which could lead to synchronization issues. Consider combining them into a single state.

@@ -252,6 +337,19 @@ export const NodeGenericInputField: FC<{

switch (propSchema.type) {
case "string":
if ("format" in propSchema && propSchema.format === "date-time") {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jsonschema converts data time to type string with format date-time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant