-
Notifications
You must be signed in to change notification settings - Fork 44.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(platform): Simplify Credentials UX #8524
Merged
Pwuts
merged 16 commits into
dev
from
kpczerwinski/open-1999-credentials-system-ux-improvements
Nov 12, 2024
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
0842f20
Update Credentials UX
kcze 30fbba3
Format backend
kcze 800b8e3
Fix `discriminatorValue`
kcze 8fb652d
Merge branch 'dev' into kpczerwinski/open-1999-credentials-system-ux-…
aarushik93 33ba822
Merge branch 'dev' into kpczerwinski/open-1999-credentials-system-ux-…
ntindle 3f54524
Merge branch 'dev' into kpczerwinski/open-1999-credentials-system-ux-…
kcze 4d09e53
Hide system credentials in Profile
kcze f64a0b4
Deselect non existing credentials
kcze f9a3993
Lint
kcze e143754
Merge branch 'dev' into kpczerwinski/open-1999-credentials-system-ux-…
Torantulino 7f4eedd
Fixes
kcze 1cb3cec
Merge branch 'dev' into kpczerwinski/open-1999-credentials-system-ux-…
ntindle c2a9ef7
Updates
kcze 32bc04b
Fix credentials input
kcze 58d01e1
Merge branch 'dev' into kpczerwinski/open-1999-credentials-system-ux-…
kcze 9f0e386
Merge branch 'dev' into kpczerwinski/open-1999-credentials-system-ux-…
Pwuts File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note: this really has to be considered a tempfix. Scopes are provider-specific. So is
supported_credential_types
. TheCredentialsField
was made to handle credentials from a specific provider. If a block supports multiple providers, the discrimination logic should be handled outside theCredentialsField
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See also #8524 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I'd like to leave this discussion here for reference in the follow-up PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I'm happy for us to merge this as a much needed temp hotfix and we can adjust that in a follow up.