Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform): Expose DB Manager Port #8424

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

aarushik93
Copy link
Contributor

Background

A change was made so that the rest server now uses the DB Manager inside of executor. So we have to expose that port for use

Changes πŸ—οΈ

Expose port 8005 on the deployment and service

Testing πŸ”

Note

Only for the new autogpt platform, currently in autogpt_platform/

  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

@aarushik93 aarushik93 requested a review from a team as a code owner October 24, 2024 15:07
@github-actions github-actions bot added the platform/backend AutoGPT Platform - Back end label Oct 24, 2024
Copy link

PR Reviewer Guide πŸ”

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 πŸ”΅πŸ”΅βšͺβšͺβšͺ
πŸ§ͺΒ No relevant tests
πŸ”’Β No security concerns identified
⚑ Recommended focus areas for review

Port Configuration
Verify that the newly added DB Manager port (8005) is correctly configured and doesn't conflict with existing ports.

Service Configuration
Ensure that the new DB Manager port is properly exposed in the service configuration and that the selector is correctly set.

Development Configuration
Confirm that the DB Manager service configuration in the development values file is consistent with the production configuration.

@aarushik93 aarushik93 merged commit 643c334 into dev Oct 24, 2024
6 checks passed
@aarushik93 aarushik93 deleted the aarushikansal/expose-db-manager-ports branch October 24, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: βœ… Done
Development

Successfully merging this pull request may close these issues.

2 participants