fix: compatibility with navionics which only accepts $GP for RMC #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just noticed this PR/commit. Seems like this could cause issues with current installs as users may be filtering based on $IIRMC like I do with kplex. (I have an always on GPS that outputs $GPRMC, when my N2K network is powered up kplex sees the $IIRMC output from signalk-to-nmea0183 and switches over to it.) Defaulting to $IIRMC and (at some point) adding the ability to modify the talkerID in the signalk-server-node GUI would be preferred to this work around. $SKRMC! |
|
@davidsanner, the addition of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets compatibility with
navionicswhich only accepts$GPforRMC, GGA & GLLas talkerID (#41).It is not yet possible to modify the talkerID in the signalk-server-node GUI.
A server evolution must be done to be able to update an existing configuration of a plugin without generating an error.