-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GGA: gnssMethodQuality is numeric #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be really great if you could also add an automated test to assert that the output matches input. Take a look at the existing tests under test
directory - copy for example MWV.js, modify the input and change the output to match, then npm test
to run the tests.
Hi @tkurki , I'm desperate. I've tried writing a test for GGA and it somehow doesn't work.
But "navigation.datetime" and "navigation.position" seems to work Result looks like this: Any Ideas? |
I think, I'm done. If you want, you can merge now Regards |
Hi,
here is fix for correct construction of GGA set with GPS quality as integer
Fixes #40
Regards
free-x