Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GGA: gnssMethodQuality is numeric #40

Merged
merged 6 commits into from
Aug 24, 2019
Merged

Conversation

free-x
Copy link
Contributor

@free-x free-x commented Aug 15, 2019

Hi,
here is fix for correct construction of GGA set with GPS quality as integer

Fixes #40

Regards
free-x

Copy link
Member

@tkurki tkurki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be really great if you could also add an automated test to assert that the output matches input. Take a look at the existing tests under test directory - copy for example MWV.js, modify the input and change the output to match, then npm test to run the tests.

sentences/GGA.js Show resolved Hide resolved
@free-x free-x mentioned this pull request Aug 15, 2019
@free-x
Copy link
Contributor Author

free-x commented Aug 20, 2019

Hi @tkurki ,

I'm desperate. I've tried writing a test for GGA and it somehow doesn't work.
I don't know why something like that just delivers zero.

     app.streambundle.getSelfStream('navigation.gnss.methodQuality').push('DGNSS fix')
     app.streambundle.getSelfStream('navigation.gnss.satellites').push(6)
     app.streambundle.getSelfStream('navigation.gnss.horizontalDilution').push(1.2)
     app.streambundle.getSelfStream('navigation.gnss.antennaAltitude').push(18.893)
     app.streambundle.getSelfStream('navigation.gnss.geoidalSeparation').push(-25.669)
     app.streambundle.getSelfStream('navigation.gnss.differentialAge').push(2.0)
     app.streambundle.getSelfStream('navigation.gnss.differentialReference').push('0031')

But "navigation.datetime" and "navigation.position" seems to work

Result looks like this:
$IIGGA,172814,3723.4659,N,12202.2696,W,0,0,0,0,M,0,M,,*52

Any Ideas?
Regards
free-x

test/GGA.js Outdated Show resolved Hide resolved
@free-x
Copy link
Contributor Author

free-x commented Aug 23, 2019

@tkurki

I think, I'm done. If you want, you can merge now

Regards
free-x

@tkurki tkurki merged commit 32fe4be into SignalK:master Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants