Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: show list of apps being installed in the app store #1790

Merged
merged 9 commits into from
Nov 23, 2024

Conversation

sbender9
Copy link
Member

there's currently no easy way to see which apps are being installed and know when all are finished

there's currently no easy way to see which apps are being installed and know when all are finished
@sbender9 sbender9 requested a review from tkurki September 12, 2024 12:16
@sbender9
Copy link
Member Author

@tkurki should I just turn off the react/no-is-mounted rule for now?

@tkurki
Copy link
Member

tkurki commented Sep 19, 2024

I find this a bit confusing

  • hit a few [Install] buttons
  • [Installing (n]] pill appears
  • install finishes, the individual module lines show installed status
  • [Installing (n]] pill remains and number stays at maximum install queue length??

I think the number should show the install queue length plus the one that is being installed and when done the pill should go away.

There is another confusion that is more obvious with this change: Installed list does not show the newly installed modules. Maybe it should? But that was already there...

@tkurki tkurki merged commit 1f329d4 into master Nov 23, 2024
4 checks passed
@tkurki tkurki deleted the installing-list branch November 23, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants