feature: add ability to send NMEA 2000 out with the Data Fiddler #1755
Conversation
There was a problem hiding this comment.
I think this is a cool idea, but I think it needs a little more work to be usable for end users.
Could we update the textarea description with something that would describe this option and mention the specific formats that can be used? We have a bit of documentation for them at /documentation/develop/plugins/deltas.html?highlight=NMEA%202000%20json#sending-nmea-2000-data-from-a-plugin so we could link there.
The N2K button is now next to Beatify JSON button, when its function is closer to send to server
We have nmea2000OutAvailable, the button could be shown only when that is available? And the button could be enabled only when the input is valid for sending n2k.
We are spelling out NMEA 2000 in the textarea description, let's use it here also. How about naming the button Send as PGN to server's NMEA2000 connection? Too long maybe...It is always a bit hard to understand what is out and in....the textarea is under Input and then you have Output on the right, but the input here is for sending data OUT from the server, not into the server for processing....
src/interfaces/playground.js
Outdated
| @@ -114,6 +115,13 @@ module.exports = function (app) { | |||
| return | |||
| } | |||
|
|
|||
| if (sendToN2K && type != 'n2k-json' && type != 'n2k') { | |||
| res.status(400).json({ | |||
| error: 'PLease enter NMEA 2000 json format or Actisense format' | |||
|
Do you think the ability to send arbitrary PGNs should be available only for admin users? |
Yes, and this currently does require admin user. it's checking allowConfigure() |
|
@tkurki I think I have addressed everything and should be ready to go |
No description provided.