Add Admin UI eslint code check; fix bugs in Restore and SourcePriorities #1725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkurki
force-pushed
the
admin-ui-eslint
branch
2 times, most recently
from
828257c to
fa30c5d
Compare
It looks like there were two actual bugs, related to an earlier switch from using lodash to using individual lodash functions. One in Restore and the other in SourcePriorities. Not going to dig into those deeper at this time, as the fixes seem to be straightforward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code structure check with eslint indicates there have been at least two bugs, one in Restore and the other in SourcePriorities. Not going to dig into these deeper at this time, as the missing lodash has been absent for some time, replaced with directly using individual lodash functions.