fix: reduce ws meta tracking memory consumption #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panaaj
approved these changes
Apr 14, 2024
Fixes #1717. Reduce memory consumption of string values used in tracking what metadata we have sent for a ws connection by keeping a cache of shared string values for this. This will deduplicate the values and help with memory consumption with a large number of AIS targets and multiple ws connections. The cache is purged every 30 minutes to get rid of data for AIS targets that have disappeared.
tkurki
force-pushed
the
fix-reduce-sentmeta-memory
branch
from
213cec1 to
a47ee19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1717.
Reduce memory consumption of string values used in tracking what metadata we have sent for a ws connection by keeping a cache of shared string values for this. This will deduplicate the values and help with memory consumption with a large number of AIS targets and multiple ws connections.
The cache is purged every 30 minutes to get rid of data for AIS targets that have disappeared.