Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-signed cert generation issue with pem (OpenSSL v3). Fixed by using devcert #1503

Merged
merged 2 commits into from
Dec 10, 2022

Conversation

KEGustafsson
Copy link
Contributor

@KEGustafsson KEGustafsson commented Dec 8, 2022

pem package is causing error when trying to generate self-signed certs. This PR changes pem to devcert.

Issue noticed during SSL testing & cert generation:
Error: RSA PRIVATE KEY not found from openssl output

Dexus/pem has open issues related to this topic, e.g. OpenSSL v3 support and there is no progress to fix it.

davewasmer/devcert package is working correctly and seems to be active and maintained .

@KEGustafsson
Copy link
Contributor Author

KEGustafsson commented Dec 8, 2022

Mocha test timout needed to be increased to pass the testing. Now time is doubled from 10000ms to 20000ms

Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

@tkurki tkurki added the fix label Dec 8, 2022
@KEGustafsson KEGustafsson changed the title fix: change pem to devcert Self-signed cert generations issue with pem (OpenSSL v3). Fixed by using devcert Dec 8, 2022
@KEGustafsson KEGustafsson changed the title Self-signed cert generations issue with pem (OpenSSL v3). Fixed by using devcert Self-signed cert generation issue with pem (OpenSSL v3). Fixed by using devcert Dec 8, 2022
@tkurki tkurki merged commit 486c4f6 into SignalK:master Dec 10, 2022
@KEGustafsson KEGustafsson deleted the devcert_ssl branch December 10, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants