Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: add GNS sentence #232

Merged
merged 5 commits into from
Jan 4, 2023
Merged

feature: add GNS sentence #232

merged 5 commits into from
Jan 4, 2023

Conversation

RoeeDev
Copy link
Contributor

@RoeeDev RoeeDev commented Nov 22, 2022

Hi,
I Added the GNS sentence to the NMEA parser, hope I did it well.
Thanks for all your great work with SignalK!

tkurki
tkurki requested changes Nov 23, 2022
View reviewed changes
Copy link
Member

@tkurki tkurki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! The only problem is that some of this stuff is not covered by the Signal K specification, which is probably the reason this was never added here.

See my more detailed comments.

hooks/GNS.js Outdated Show resolved Hide resolved
hooks/GNS.js Outdated Show resolved Hide resolved
hooks/GNS.js Outdated Show resolved Hide resolved
tkurki
tkurki requested changes Dec 26, 2022
View reviewed changes
Copy link
Member

@tkurki tkurki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - a few more stylistic fixes, if you will. Sorry about the piecemeal review.

hooks/GNS.js Outdated Show resolved Hide resolved
hooks/GNS.js Outdated Show resolved Hide resolved
hooks/GNS.js Outdated Show resolved Hide resolved
@tkurki tkurki added the feature label Dec 28, 2022
@tkurki
Copy link
Member

tkurki commented Dec 28, 2022

👍 - now just fix it so it/tests work and we're done!

@RoeeDev
Copy link
Contributor Author

RoeeDev commented Dec 29, 2022

Fixed the test, I had a small typo in the test file.
Hopefully it should work now.

@tkurki
Copy link
Member

tkurki commented Dec 29, 2022

You can not compare objects in the test with value.should.equal, it should be value.should.deep.equal. https://stackoverflow.com/questions/13225274/the-difference-between-assert-equal-and-assert-deepequal-in-javascript-testing-w

The checksum for the empty sentence is not correct, must end with *32. https://nmeachecksum.eqth.net/

@tkurki tkurki merged commit eb244d1 into SignalK:master Jan 4, 2023
@tkurki
Copy link
Member

tkurki commented Jan 4, 2023

Thanks! Published in version v3.13.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkurki tkurki tkurki approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RoeeDev @tkurki