Add File watcher and Mapbox Style support #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing the use of a shared path aligns better with multi-provider support. Tile paths have a fully qualified path, remove use of relative path.
This is appended to the url path to the mapbox style json file.
Ensure operation behind proxy is not impacted.
Ensure operation behind proxy is not impacted.
panaaj
changed the title
|
@tkurki Can you please review and if all is OK it's good to publish. This code seemed to solve Freeboard-SK issue SignalK/freeboard-sk#211 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes:
Adds a file watcher to charts folders to detect new files placed in the folder. This makes the new charts available to subsequent requests without having to restart the plugin (Feature request - Possible to re-read charts on the fly? #28).
Adds support for processing mapbox style json files placed in the folder paths configured in the plugin settings, which will in-turn produce a chart metadata entry.