Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique SSID for each ESP #108

Merged
merged 5 commits into from
Apr 28, 2020
Merged

Unique SSID for each ESP #108

merged 5 commits into from
Apr 28, 2020

Conversation

ba58smith
Copy link
Collaborator

See Issue #86.

@ba58smith
Copy link
Collaborator Author

DO NOT MERGE THIS YET. Although it does what I intended it to do, there appears to be a bug way down deep in Wifi Manager that doesn't erase the SSID and pw of the configuration UI when resetSettings() is called. If it's not erasing those, then it's probably also not erasing any custom parameters, which is what this PR is all about. tzapu/WiFiManager#142

@mairas
Copy link
Collaborator

mairas commented Apr 15, 2020

Looks good to me!

@ba58smith
Copy link
Collaborator Author

ba58smith commented Apr 15, 2020 via email

@ba58smith
Copy link
Collaborator Author

OK, this PR works. Each of my four ESP's is now broadcasting a custom SSID when my onboard wifi is turned off (the wife that all four of the ESP's are supposed to connect to).
If you ever have what appears to be an outdated SSID being broadcast for a particular ESP, try the PlatformIO option "Erase Flash", and then upload the new firmware.
Issue #87 is still open, and is made even more obvious by this PR, as you'll now see a separate SSID being broadcast by all of your ESP's any time your wifi is not available.

@ba58smith ba58smith merged commit a2cdc1b into SignalK:master Apr 28, 2020
@ba58smith ba58smith deleted the uniqueSSID branch April 28, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants