feat: toggle off infra monitoring #6787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 9c01cec in 15 seconds
More details
- Looked at
19lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. frontend/src/pages/InfrastructureMonitoring/InfrastructureMonitoringPage.tsx:8
- Draft comment:
Ensure that removing theKubernetesimport does not affect other parts of the codebase that might rely on it. - Reason this comment was not posted:
Confidence changes required:50%
The import statement for Kubernetes is removed, but there might be other parts of the codebase that still reference it. It's important to ensure that removing this import doesn't break any functionality.
2. frontend/src/pages/InfrastructureMonitoring/InfrastructureMonitoringPage.tsx:5
- Draft comment:
Avoid using thecomponent/index.tsxfile structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_e5mhbCMxRFZqIvWT
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
srikanthccv
approved these changes
Jan 9, 2025
amlannandy
force-pushed
the
feat/infra-monitoring-fix
branch
from
9c01cec to
439500c
Compare
amlannandy
added a commit
that referenced
this pull request
Jan 16, 2025
amlannandy
added a commit
that referenced
this pull request
Jan 16, 2025
hudsongeovane
pushed a commit
to hudsongeovane/signoz
that referenced
this pull request
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Toggle off infra monitoring feature
Related Issues / PR's
Screenshots
Affected Areas and Manually Tested Areas
Infra Monitoring section
Important
Remove
KubernetesfromroutesinInfrastructureMonitoringPage.tsxto disable Kubernetes infra monitoring.Kubernetesfromroutesarray inInfrastructureMonitoringPage.tsx, disabling Kubernetes infra monitoring.This description was created by
for 9c01cec. It will automatically update as commits are pushed.