Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement nodes list table in infra monitoring #6615

Draft
wants to merge 2 commits into
base: feat/infra-monitoring-k8s
Choose a base branch
from

Conversation

amlannandy
Copy link
Member

Summary

Implement the nodes list table in Infra Monitoring

Related Issues / PR's

N/A

Screenshots

N/A

Affected Areas and Manually Tested Areas

Infra Monitoring section

@github-actions github-actions bot added the enhancement New feature or request label Dec 11, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@@ -14,6 +14,13 @@ import {
} from 'components/QuickFilters/QuickFilters';
import { DataTypes } from 'types/api/queryBuilder/queryAutocompleteResponse';

export interface IEntityColumn {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using this instead of IPodColumn. As we're reusing it, thought it should have a more generic name.
We can remove IPodColumn in the end. I didn't rename it now to avoid conflicts.

@@ -127,4 +128,11 @@ function K8sHeader({
);
}

K8sHeader.defaultProps = {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made these fields optional for list views where there is no metadata to show

@amlannandy amlannandy force-pushed the feat/infra-monitoring-k8s-nodes branch from ef641e7 to 2e8350b Compare December 11, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant