-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add infra monitoring - host lists - usage events #6536
feat: add infra monitoring - host lists - usage events #6536
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to b21133d in 2 minutes and 3 seconds
More details
- Looked at
148
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. frontend/src/components/HostMetricsDetail/HostMetricsDetails.tsx:151
- Draft comment:
TheuseCallback
on this line is missing dependencies. It useshost
andGetMinMax
, which should be included in the dependency array. This applies to otheruseCallback
hooks in this file as well. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_o5Adwnr9GOFe9DjM
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on c9fce7c in 16 seconds
More details
- Looked at
365
lines of code in9
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. frontend/src/components/HostMetricsDetail/WaitlistFragment/WaitlistFragment.tsx:1
- Draft comment:
The PR description mentions addinglogEvent
calls inHostMetricsDetails.tsx
andHostsList.tsx
, but these files are not present in the diff. Please ensure all intended changes are included in the PR. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_RYFIWjU7dgKgTrtM
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
3a5aeb2
into
fix/no-host-screen-and-documentation
* feat: improve empty hosts, incorrect metrics and no filter views * feat: add infra monitoring - host lists - usage events (#6536) * feat: add usasge events * feat: add reqrest early access events --------- Co-authored-by: Srikanth Chekuri <[email protected]>
feat: add infra monitoring - host lists - usage events
Important
Add logging for user interactions in Infra Monitoring and update UI components and localization.
logEvent
calls inHostMetricsDetails.tsx
for page visits, time updates, log and trace filter applications, and explore clicks.logEvent
calls inHostsList.tsx
for page visits, filter applications, and item clicks.WaitlistFragment
component inWaitlistFragment.tsx
for handling waitlist interactions.Containers.styles.scss
andProcesses.styles.scss
for layout adjustments.waitlist_message
and addwaitlist_success_message
ininfraMonitoring.json
foren-GB
anden
locales.menuItems.tsx
for Infra Monitoring fromPackagePlus
toBoxes
.This description was created by for c9fce7c. It will automatically update as commits are pushed.