Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add infra monitoring - host lists - usage events #6536

Conversation

YounixM
Copy link
Member

@YounixM YounixM commented Nov 26, 2024

feat: add infra monitoring - host lists - usage events


Important

Add logging for user interactions in Infra Monitoring and update UI components and localization.

  • Logging:
    • Add logEvent calls in HostMetricsDetails.tsx for page visits, time updates, log and trace filter applications, and explore clicks.
    • Add logEvent calls in HostsList.tsx for page visits, filter applications, and item clicks.
  • UI Components:
    • Add WaitlistFragment component in WaitlistFragment.tsx for handling waitlist interactions.
    • Update styles in Containers.styles.scss and Processes.styles.scss for layout adjustments.
  • Localization:
    • Update waitlist_message and add waitlist_success_message in infraMonitoring.json for en-GB and en locales.
  • Misc:
    • Change icon in menuItems.tsx for Infra Monitoring from PackagePlus to Boxes.

This description was created by Ellipsis for c9fce7c. It will automatically update as commits are pushed.

@github-actions github-actions bot added the enhancement New feature or request label Nov 26, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to b21133d in 2 minutes and 3 seconds

More details
  • Looked at 148 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. frontend/src/components/HostMetricsDetail/HostMetricsDetails.tsx:151
  • Draft comment:
    The useCallback on this line is missing dependencies. It uses host and GetMinMax, which should be included in the dependency array. This applies to other useCallback hooks in this file as well.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_o5Adwnr9GOFe9DjM


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on c9fce7c in 16 seconds

More details
  • Looked at 365 lines of code in 9 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. frontend/src/components/HostMetricsDetail/WaitlistFragment/WaitlistFragment.tsx:1
  • Draft comment:
    The PR description mentions adding logEvent calls in HostMetricsDetails.tsx and HostsList.tsx, but these files are not present in the diff. Please ensure all intended changes are included in the PR.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_RYFIWjU7dgKgTrtM


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@YounixM YounixM merged commit 3a5aeb2 into fix/no-host-screen-and-documentation Nov 26, 2024
7 of 8 checks passed
@YounixM YounixM deleted the feat/infra-monitoring-hosts-usage-events branch November 26, 2024 10:48
YounixM added a commit that referenced this pull request Nov 27, 2024
* feat: improve empty hosts, incorrect metrics and no filter views

* feat: add infra monitoring - host lists - usage events (#6536)

* feat: add usasge events

* feat: add reqrest early access events

---------

Co-authored-by: Srikanth Chekuri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants