Timezone basic functionality

[ahmadshaheer]

Summary

• a context for managing the current timezone
• fallback to browser timezone if timezone is not set
• set the preferred timezone in local storage for now (will work on storing it in preference API)
• handle the timezone preferences using the state in timezone context

Related Issues / PR's

Part of https://github.com/SigNoz/engineering-pod/issues/2005

Screenshots

NA

Affected Areas and Manually Tested Areas

---

Important

Adds timezone management with context provider, browser fallback, and local storage, updating components to reflect timezone changes.

• Timezone Management:
  • Introduces TimezoneProvider in providers/Timezone.tsx to manage timezone context.
  • Fallback to browser timezone if no preferred timezone is set.
  • Stores preferred timezone in local storage (LOCALSTORAGE.PREFERRED_TIMEZONE).
• Component Updates:
  • CustomTimePicker.tsx, CustomTimePickerPopoverContent.tsx, and TimezonePicker.tsx now use useTimezone hook to access timezone context.
  • TimezoneAdaptation.tsx allows clearing timezone override, reverting to browser timezone.
• UI Changes:
  • Displays active timezone offset in CustomTimePicker and CustomTimePickerPopoverContent.
  • Adds "Clear override" button in TimezoneAdaptation when timezone is overridden.

^{This description was created by for 5048115. It will automatically update as commits are pushed.}

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to 676e32e in 44 seconds

More details

• Looked at 396 lines of code in 8 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. frontend/src/providers/Timezone.tsx:76

• Draft comment:
  Storing the timezone as a JSON string in localStorage is inconsistent with how it's retrieved. Consider storing it as a plain string instead.
• Reason this comment was not posted:
  Marked as duplicate.

Workflow ID: wflow_gm33mh7sTACsIzlq

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[ellipsis-dev]

👍 Looks good to me! Incremental review on e012f10 in 45 seconds

More details

• Looked at 77 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 3 drafted comments based on config settings.

1. frontend/src/providers/Timezone.tsx:34

• Draft comment:
  Ensure getTimezoneObjectByTimezoneString does not return null or handle the case where it might return null to avoid runtime errors.
• Reason this comment was not posted:
  Comment did not seem useful.

2. frontend/src/components/CustomTimePicker/timezoneUtils.ts:136

• Draft comment:
  Ensure getTimezoneObjectByTimezoneString does not return null or handle the case where it might return null to avoid runtime errors.
• Reason this comment was not posted:
  Marked as duplicate.

3. frontend/src/providers/Timezone.tsx:27

• Draft comment:
  Avoid using the component/index.tsx file structure approach, as it makes it difficult to debug and find components using global search tools like VS Code.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable:
  The comment is not relevant to the changes made in this diff. The file structure mentioned in the comment does not apply to the file being reviewed. Therefore, the comment should be deleted.
  I might be missing some context about the overall project structure, but based on the file path and name, the comment does not seem applicable.
  The file path and name provide enough context to determine that the comment is not relevant to this specific file.
  The comment is not about a change made in this diff and should be deleted.

Workflow ID: wflow_DFcP49jSYbkqMl2K

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[SagarRajput-7]

NIT: Consider introducing a configurable fallback timezone for cases where both localStorage and browserTimezone fail

[ahmadshaheer]

@SagarRajput-7, here the browserTimezone will never fail, IMO, as dayjs can always get browser's timezone.

[ellipsis-dev]

👍 Looks good to me! Incremental review on 5048115 in 22 seconds

More details

• Looked at 13 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. frontend/src/providers/Timezone.tsx:57

• Draft comment:
  The check for timezone.value is good for preventing errors with undefined values. Ensure timezone always has a value property when valid.
• Reason this comment was not posted:
  Confidence changes required: 20%
  The updateTimezone function correctly checks for a valid timezone.value before proceeding. This prevents potential errors from undefined values.

Workflow ID: wflow_9hosx07IsU101fJn

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>