-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use the license v2 key to fill licenses v3 on startup #6468
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 1d4d42f in 1 minute and 9 seconds
More details
- Looked at
31
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_Z1UHQEkqRdoM1z5u
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on a75b4f8 in 12 seconds
More details
- Looked at
33
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. ee/query-service/license/manager.go:80
- Draft comment:
The error handling forvalidate.ValidateLicenseV3
andm.repo.InsertLicenseV3
is repetitive. Consider using a helper function to handle errors, reducing code duplication. - Reason this comment was not posted:
Confidence changes required:50%
The error handling forvalidate.ValidateLicenseV3
andm.repo.InsertLicenseV3
is repetitive. It can be improved by using a helper function to handle errors, reducing code duplication.
Workflow ID: wflow_QxCN3NXD3YfzRCCP
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
contributes to - https://github.com/SigNoz/engineering-pod/issues/1035 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on b1cd933 in 9 seconds
More details
- Looked at
14
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. ee/query-service/license/manager.go:88
- Draft comment:
Consider logging a more specific error message whenInsertLicenseV3
fails for reasons other thanErrorConflict
. This will help in debugging issues more effectively. - Reason this comment was not posted:
Confidence changes required:50%
The error handling forInsertLicenseV3
is not consistent with the rest of the codebase. It should return a more specific error message.
Workflow ID: wflow_2xrGZy5ckVow7qz9
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Summary
Related Issues / PR's
Screenshots
NA
Affected Areas and Manually Tested Areas