Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect formula for apdex #6460

Merged
merged 2 commits into from
Nov 19, 2024
Merged

fix: incorrect formula for apdex #6460

merged 2 commits into from
Nov 19, 2024

Conversation

srikanthccv
Copy link
Member

@srikanthccv srikanthccv commented Nov 16, 2024

Summary

The formula was incorrect.


Important

Corrects Apdex formula in constant.ts to handle over-counting for traces and delta span metrics.

  • Behavior:
    • Corrects Apdex formula in constant.ts for APDEX_TRACES and APDEX_DELTA_SPAN_METRICS to ((B + C)/2)/A to handle over-counting.
    • Adjusts comments to clarify the formula logic and the handling of cumulative counts.

This description was created by Ellipsis for 17e16cf. It will automatically update as commits are pushed.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 17e16cf in 6 seconds

More details
  • Looked at 21 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. frontend/src/container/MetricsApplication/constant.ts:45
  • Draft comment:
    The comment mentions cumulative counts, which might be misleading since the formula was updated to match APDEX_TRACES. Consider revising the comment for clarity.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The formula for APDEX_DELTA_SPAN_METRICS was updated to match the logic of APDEX_TRACES, which seems correct based on the description. However, the comment above APDEX_DELTA_SPAN_METRICS still mentions cumulative counts, which might be misleading.

Workflow ID: wflow_26sZ0mdaPjo7IDh6


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@github-actions github-actions bot added the bug Something isn't working label Nov 16, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@srikanthccv srikanthccv enabled auto-merge (squash) November 19, 2024 05:34
@srikanthccv srikanthccv merged commit c93cf1c into develop Nov 19, 2024
16 checks passed
@srikanthccv srikanthccv deleted the fix-formula branch November 19, 2024 05:42
YounixM pushed a commit that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants