Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing alert telemetry #6459

Merged
merged 3 commits into from
Nov 16, 2024
Merged

chore: add missing alert telemetry #6459

merged 3 commits into from
Nov 16, 2024

Conversation

srikanthccv
Copy link
Member

@srikanthccv srikanthccv commented Nov 16, 2024

Summary

We capture this here.

if rule.RuleType == RuleTypeAnomaly {
alertsInfo.AnomalyBasedAlerts = alertsInfo.AnomalyBasedAlerts + 1
}
I forgot it needs to be explicitly added again the telemetry.go


Important

Add anomalyBasedAlerts to telemetry data in createTelemetry() in telemetry.go.

  • Telemetry:
    • Add anomalyBasedAlerts to telemetry data in createTelemetry() in telemetry.go.

This description was created by Ellipsis for bbe1919. It will automatically update as commits are pushed.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the chore label Nov 16, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to bbe1919 in 1 minute and 8 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. pkg/query-service/telemetry/telemetry.go:350
  • Draft comment:
    Ensure that alertsInfo.AnomalyBasedAlerts is correctly populated in the alertsInfoCallback to avoid sending incorrect telemetry data. This applies to other telemetry fields as well.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The added line in the PR is consistent with the existing pattern for telemetry data collection. It adds a new telemetry field for anomaly-based alerts, which is already being captured elsewhere in the codebase. This addition is necessary for consistency and completeness in telemetry reporting.
2. pkg/query-service/telemetry/telemetry.go:350
  • Draft comment:
    Looks good. No issues found with the change.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The code change is appropriate and does not violate any of the specified rules.

Workflow ID: wflow_t94KdQMJpWu3AiZz


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

pkg/query-service/telemetry/telemetry.go Show resolved Hide resolved
@srikanthccv srikanthccv enabled auto-merge (squash) November 16, 2024 19:05
@srikanthccv srikanthccv merged commit 656d1c2 into develop Nov 16, 2024
16 checks passed
@srikanthccv srikanthccv deleted the chore-telemetry branch November 16, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants