-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add missing alert telemetry #6459
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to bbe1919 in 1 minute and 8 seconds
More details
- Looked at
12
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. pkg/query-service/telemetry/telemetry.go:350
- Draft comment:
Ensure thatalertsInfo.AnomalyBasedAlerts
is correctly populated in thealertsInfoCallback
to avoid sending incorrect telemetry data. This applies to other telemetry fields as well. - Reason this comment was not posted:
Confidence changes required:50%
The added line in the PR is consistent with the existing pattern for telemetry data collection. It adds a new telemetry field for anomaly-based alerts, which is already being captured elsewhere in the codebase. This addition is necessary for consistency and completeness in telemetry reporting.
2. pkg/query-service/telemetry/telemetry.go:350
- Draft comment:
Looks good. No issues found with the change. - Reason this comment was not posted:
Confidence changes required:0%
The code change is appropriate and does not violate any of the specified rules.
Workflow ID: wflow_t94KdQMJpWu3AiZz
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Summary
We capture this here.
signoz/pkg/query-service/rules/db.go
Lines 602 to 604 in 0acf39a
telemetry.go
Important
Add
anomalyBasedAlerts
to telemetry data increateTelemetry()
intelemetry.go
.anomalyBasedAlerts
to telemetry data increateTelemetry()
intelemetry.go
.This description was created by for bbe1919. It will automatically update as commits are pushed.