feat: added table column and row logic for the new api response structure for producer overview #6433
Conversation
…ture for prodcure overview
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 87fe6cd in 1 minute and 16 seconds
More details
- Looked at
209lines of code in4files - Skipped
0files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. frontend/src/pages/MessagingQueues/MQDetails/MQTables/MQTables.tsx:36
- Draft comment:
Typo in function namegetColumnsForProduderLatencyOverview. It should begetColumnsForProducerLatencyOverview. This typo is also present in other files where this function is used. - Reason this comment was not posted:
Marked as duplicate.
2. frontend/src/pages/MessagingQueues/MQDetails/MQTables/MQTables.tsx:197
- Draft comment:
Typo in function namegetColumnsForProduderLatencyOverview. It should begetColumnsForProducerLatencyOverview. This typo is also present in other files where this function is used. - Reason this comment was not posted:
Marked as duplicate.
3. frontend/src/pages/MessagingQueues/MQDetails/MQTables/getTopicThroughputOverview.ts:8
- Draft comment:
Typo in function namegetColumnsForProduderLatencyOverview. It should begetColumnsForProducerLatencyOverview. This typo is also present in other files where this function is used. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_vdZRYxKuNkKIW39E
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
frontend/src/pages/MessagingQueues/MQDetails/MQTables/MQTableUtils.tsx
Outdated
Show resolved
Hide resolved
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 531becc in 29 seconds
More details
- Looked at
36lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_zPS8AVigd4SULVQJ
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| }; | ||
| } | ||
|
|
||
| export const getColumnsForProducerLatencyOverview = ( |
There was a problem hiding this comment.
The function name was misspelled as getColumnsForProduderLatencyOverview. It should be corrected to getColumnsForProducerLatencyOverview for consistency and to avoid potential issues. This issue is also present in MQTables.tsx.
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
vikrantgupta25
changed the title
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
| @@ -126,7 +131,13 @@ function MessagingQueuesTable({ | |||
| tableApi: ( | |||
There was a problem hiding this comment.
why is tableApi getting passed on like this ?
| ) { | ||
| setColumns( | ||
| getColumnsForProducerLatencyOverview( | ||
| (data?.payload as TopicThroughputProducerOverviewResponse['payload']) |
There was a problem hiding this comment.
why as TopicThroughputProducerOverviewResponse['payload']?
| setColumns( | ||
| getColumnsForProducerLatencyOverview( | ||
| (data?.payload as TopicThroughputProducerOverviewResponse['payload']) | ||
| .result[0].list, |
There was a problem hiding this comment.
will result[0].list always be present ?
| SuccessResponse<MessagingQueuesPayloadProps['payload']> | ErrorResponse | ||
| | SuccessResponse< | ||
| ( | ||
| | MessagingQueuesPayloadProps |
There was a problem hiding this comment.
this is ideally not a good structure to expect different types of responses based on different conditions.
Summary
We have a new API response structure, due to which need to change the column and table data handling -
slack thread for reference - https://signoz-team.slack.com/archives/C070V9S041L/p1731413223737439
Related Issues / PR's
Screenshots
Screen.Recording.2024-11-13.at.5.14.28.AM.mov
Affected Areas and Manually Tested Areas
Important
Add logic for handling new API response structure for producer latency overview in messaging queues.
getColumnsForProducerLatencyOverviewandgetTableDataForProducerLatencyOverviewinMQTableUtils.tsxfor new API response structure.TopicThroughputProducerOverviewResponseinterface inMQTableUtils.tsx.MessagingQueuesTableinMQTables.tsxto use new utility functions for producer latency overview.getTopicThroughputOverviewingetTopicThroughputOverview.tsto returnTopicThroughputProducerOverviewResponse.evalTimefromMessagingQueueOverview.tsx.This description was created by
for 531becc. It will automatically update as commits are pushed.