chore: return proper http codes on unique constraint error

[vikrantgupta25]

Summary

• return proper http error codes for conflicting errors in licenses v3

Related Issues / PR's

Screenshots

Affected Areas and Manually Tested Areas

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 7421ef3 in 51 seconds

More details

• Looked at 73 lines of code in 3 files
• Skipped 0 files when reviewing.
• Skipped posting 3 drafted comments based on config settings.

1. ee/query-service/license/db.go:275

• Draft comment:
  The function now returns *model.ApiError instead of error, which is consistent with the use of model.ApiError for API error handling. This change improves error handling by providing more structured error responses.
• Reason this comment was not posted:
  Confidence changes required: 10%
  The error handling in the InsertLicenseV3 function has been updated to return model.ApiError instead of error. This change is consistent with the rest of the codebase where model.ApiError is used for API error handling. The change also includes specific handling for unique constraint violations, which is a good practice for providing more informative error responses.

2. ee/query-service/license/manager.go:466

• Draft comment:
  The function now directly returns the error from InsertLicenseV3, which is a model.ApiError. This change ensures that the correct error type is propagated and is consistent with the updated error handling approach.
• Reason this comment was not posted:
  Confidence changes required: 10%
  The error handling in the ActivateV3 function has been updated to directly return the error from InsertLicenseV3, which is now a model.ApiError. This change is consistent with the updated error handling approach and ensures that the correct error type is propagated.

3. pkg/query-service/app/http_handler.go:319

• Draft comment:
  Avoid using inline styles. Use external stylesheets or styled components instead. This is also applicable in the liveTailLogs function.
• Reason this comment was not posted:
  Comment was on unchanged code.

Workflow ID: wflow_VTf6pOBlaDuGRpTV

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[vikrantgupta25]

contributes to - https://github.com/SigNoz/platform-pod/issues/325