-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add log events to alert history page #6396
chore: add log events to alert history page #6396
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 554a866 in 54 seconds
More details
- Looked at
153
lines of code in5
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. frontend/src/container/AlertHistory/Timeline/Table/Table.tsx:50
- Draft comment:
The return type ofhandleRowClick
should match the expected type foronRow
. Consider usingReact.HTMLAttributes<HTMLTableRowElement>
instead ofHTMLAttributes<AlertRuleTimelineTableResponse>
. This issue is also present inTopContributorsRows.tsx
. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_gTkhpkUuC3zF35OP
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
frontend/src/container/AlertHistory/Statistics/TopContributorsCard/TopContributorsRows.tsx
Show resolved
Hide resolved
* chore: pass active route with RouteTab's onChangeHandler * chore: add log events to alert history page --------- Co-authored-by: Srikanth Chekuri <[email protected]>
Summary
Add events to the alerts history page
Related Issues / PR's
Part of https://github.com/SigNoz/engineering-pod/issues/1952
Screenshots
NA
Affected Areas and Manually Tested Areas
Important
Add logging for user interactions on the alert history page, including tab changes and row clicks, using
logEvent
.logEvent
calls inTopContributorsRows.tsx
for row clicks to log labels.logEvent
calls inTable.tsx
for timeline table row clicks to logruleId
and labels.logEvent
inAlertDetails.tsx
to log when the Alert History tab is visited.onChangeHandler
signature inRouteTabProps
to accept astring
key instead ofVoidFunction
.onChangeHandler
usage inindex.tsx
to passactiveRoute
.handleRowClick
function inTopContributorsRows.tsx
andTable.tsx
to handle row click events.This description was created by for 554a866. It will automatically update as commits are pushed.