Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add log events to alert history page #6396

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

ahmadshaheer
Copy link
Collaborator

@ahmadshaheer ahmadshaheer commented Nov 7, 2024

Summary

Add events to the alerts history page

  • click on the alerts history tab
  • click on the top contributors
  • click on the row on the timeline view

Related Issues / PR's

Part of https://github.com/SigNoz/engineering-pod/issues/1952

Screenshots

NA

Affected Areas and Manually Tested Areas


Important

Add logging for user interactions on the alert history page, including tab changes and row clicks, using logEvent.

  • Logging:
    • Add logEvent calls in TopContributorsRows.tsx for row clicks to log labels.
    • Add logEvent calls in Table.tsx for timeline table row clicks to log ruleId and labels.
    • Add logEvent in AlertDetails.tsx to log when the Alert History tab is visited.
  • Function Signature Changes:
    • Change onChangeHandler signature in RouteTabProps to accept a string key instead of VoidFunction.
    • Update onChangeHandler usage in index.tsx to pass activeRoute.
  • Misc:
    • Add handleRowClick function in TopContributorsRows.tsx and Table.tsx to handle row click events.

This description was created by Ellipsis for 554a866. It will automatically update as commits are pushed.

Copy link

github-actions bot commented Nov 7, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
Copy link

github-actions bot commented Nov 7, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 554a866 in 54 seconds

More details
  • Looked at 153 lines of code in 5 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. frontend/src/container/AlertHistory/Timeline/Table/Table.tsx:50
  • Draft comment:
    The return type of handleRowClick should match the expected type for onRow. Consider using React.HTMLAttributes<HTMLTableRowElement> instead of HTMLAttributes<AlertRuleTimelineTableResponse>. This issue is also present in TopContributorsRows.tsx.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_gTkhpkUuC3zF35OP


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@ahmadshaheer ahmadshaheer enabled auto-merge (squash) November 20, 2024 04:30
@ahmadshaheer ahmadshaheer merged commit 20e64b5 into develop Nov 20, 2024
16 of 17 checks passed
YounixM pushed a commit that referenced this pull request Nov 20, 2024
* chore: pass active route with RouteTab's onChangeHandler

* chore: add log events to alert history page

---------

Co-authored-by: Srikanth Chekuri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants