Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo #6334

Merged
merged 1 commit into from
Oct 31, 2024
Merged

fix: typo #6334

merged 1 commit into from
Oct 31, 2024

Conversation

shivanshuraj1333
Copy link
Member

@shivanshuraj1333 shivanshuraj1333 commented Oct 31, 2024

Important

Fixes typo in buildCompositeQuery function in translator.go to correctly handle "producer-consumer-eval" context.

  • Fix:
    • Corrects typo in buildCompositeQuery function in translator.go from "producer-consumer-eva" to "producer-consumer-eval".
    • Ensures correct CompositeQuery is returned for queryContext "producer-consumer-eval".

This description was created by Ellipsis for c6be1d6. It will automatically update as commits are pushed.

Copy link

request-info bot commented Oct 31, 2024

We would appreciate it if you could provide us with more info about this issue/pr!

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to c6be1d6 in 8 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. pkg/query-service/app/integrations/messagingQueues/kafka/translator.go:367
  • Draft comment:
    The typo fix from producer-consumer-eva to producer-consumer-eval is correct and consistent with other parts of the codebase.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR fixes a typo in the string comparison for queryContext. This change is consistent with the rest of the codebase where producer-consumer-eval is used.

Workflow ID: wflow_CnkTiH6mVZb8qElG


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@shivanshuraj1333 shivanshuraj1333 merged commit b770fc2 into SigNoz:develop Oct 31, 2024
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants